dawids/lang-bootstrap
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

better error for declaring incomplete struct

Browse source
This commit is contained in:
pommicket 2022-02-14 16:58:38 -05:00
parent c15db88951
commit 0c5b34b8d0
2 changed files with 27 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
05/main.c
View file

@ -2,9 +2,6 @@
#include <string.h> #include <string.h>
int main(void) { int main(void) {
char nam[L_tmpnam];
printf("%s\n", tmpnam(nam));
return 0; return 0;
} }

28
05/parse.b
View file

@ -50,6 +50,17 @@ function type_is_floating
if *1p == TYPE_DOUBLE goto return_1 if *1p == TYPE_DOUBLE goto return_1
return 0 return 0
function type_is_incomplete_struct
argument type
local p
p = types + type
if *1p != TYPE_STRUCT goto return_0
p += 1
p = *8p
if p == 0 goto return_1
if *8p == 0 goto return_1
return 0
function functype_return_type function functype_return_type
argument ftype argument ftype
local type local type
@ -156,6 +167,9 @@ function parse_toplevel_declaration
parse_type_declarators(prefix, prefix_end, suffix, suffix_end, function_param_names) parse_type_declarators(prefix, prefix_end, suffix, suffix_end, function_param_names)
parse_base_type(base_type, base_type_end) parse_base_type(base_type, base_type_end)
b = type_is_incomplete_struct(type)
if b != 0 goto tld_incomplete_struct
; ensure rwdata_end_addr is aligned to 8 bytes ; ensure rwdata_end_addr is aligned to 8 bytes
; otherwise addresses could be screwed up ; otherwise addresses could be screwed up
rwdata_end_addr += 7 rwdata_end_addr += 7
@ -199,7 +213,11 @@ function parse_toplevel_declaration
:tl_decl_loop_done :tl_decl_loop_done
token += 16 ; skip semicolon token += 16 ; skip semicolon
goto parse_tld_ret goto parse_tld_ret
:tld_incomplete_struct
token_error(token, .str_tld_incomplete_struct)
:str_tld_incomplete_struct
string Declaration has incomplete struct as its type.
byte 0
:tl_decl_no_ident :tl_decl_no_ident
; this might actually be okay, e.g. ; this might actually be okay, e.g.
; struct Something { int x, y; } ; struct Something { int x, y; }
@ -732,6 +750,9 @@ function parse_statement
parse_type_declarators(l_prefix, l_prefix_end, l_suffix, l_suffix_end, 0) parse_type_declarators(l_prefix, l_prefix_end, l_suffix, l_suffix_end, 0)
parse_base_type(l_base_type) parse_base_type(l_base_type)
b = type_is_incomplete_struct(l_type)
if b != 0 goto local_decl_incomplete_struct
; create pseudo-entry for variable in local variables list. ; create pseudo-entry for variable in local variables list.
; this allows for int *x = malloc(sizeof *x); ; this allows for int *x = malloc(sizeof *x);
; unfortunately, it also allows int x = x; ; unfortunately, it also allows int x = x;
@ -817,6 +838,11 @@ function parse_statement
:str_local_decl_no_ident :str_local_decl_no_ident
string No identifier in declaration. string No identifier in declaration.
byte 0 byte 0
:local_decl_incomplete_struct
token_error(token, .str_local_decl_incomplete_struct)
:str_local_decl_incomplete_struct
string Location declaration has incomplete struct as its type.
byte 0
:local_decl_loop_end :local_decl_loop_end
token += 16 ; skip semicolon token += 16 ; skip semicolon
goto parse_statement_ret goto parse_statement_ret